-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating driver to usb-device 0.3.0 #39
Conversation
Thanks! I merged a PR which enforces rustfmt checks: #40 |
Should be much smaller now, thanks for the rustfmt checks! :) |
Ping back over to @Disasm - if you don't have time, I'll merge and release later today/this week, so no worries. Thanks for helping! |
Hi! I started testing the proposed changes to the driver with the variety of boards I have. The test plan is quite big and it also includes #25 which I wanted to integrate before the 0.3.0 release. So far testing is complete by ~25%. If you think that the release should be prioritized, then I can prioritize testing of this update, but otherwise my plan is to finish testing on weekend this or next week. |
Hmm, personally I'd be more inclined to release early and often, and we can add in that support once its fully tested. It won't change any of the API, so it would be simple enough to include that in a patch release. What are your thoughts on that? |
That's what I want to make sure: that usb-device 0.3.0 is fully tested together with this driver :) Ok, I will test this update next, then let's make a new release of |
Test results:
|
I found that serial test behavior depends on the USB port type used: test passes if USB 2.0 port is used, fails if USB 3.0 port is used. And this is also a bug which was present in older versions of |
This PR bumps the
usb-device
version used to 0.3.0, which I just released earlier today. I've tested these changes on Stabilizer with a USB-CDC-ACM port and verified things work as expected.Most of the changes are from rustfmt here.