Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "toString" function with IPAddress #2306

Merged
merged 2 commits into from
Mar 26, 2024
Merged

add "toString" function with IPAddress #2306

merged 2 commits into from
Mar 26, 2024

Conversation

VirensCn
Copy link
Contributor

@VirensCn VirensCn commented Mar 17, 2024 •
edited by fpistm
Loading

This PR implements the following features

  • add toString function with IPAddress

Enhancement IPAddress is missing the toString function interface？

@fpistm fpistm linked an issue Mar 18, 2024 that may be closed by this pull request
IPAddress is missing the toString function interface？ #2303
Closed
@fpistm
Copy link
Member

fpistm commented Mar 18, 2024

Hi @VirensCn
Thanks for the PR.
It seems you used implementation done in other core (esp32 ?).
I've reworked your PR to be aligned (as much as possible) to official Arduino Core API:
https://github.com/arduino/ArduinoCore-API

@fpistm fpistm added arduino compatibility enhancement New feature or request labels Mar 18, 2024
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Mar 18, 2024
@fpistm fpistm added this to the 2.8.0 milestone Mar 18, 2024
@VirensCn VirensCn closed this Mar 25, 2024
STM32 core based on ST HAL automation moved this from In progress to Done Mar 25, 2024
@VirensCn
Copy link
Contributor Author

I think I should submit the toString function for IPV4 first

@VirensCn VirensCn reopened this Mar 25, 2024
STM32 core based on ST HAL automation moved this from Done to In progress Mar 25, 2024
@VirensCn VirensCn closed this Mar 25, 2024
STM32 core based on ST HAL automation moved this from In progress to Done Mar 25, 2024
@VirensCn VirensCn reopened this Mar 25, 2024
STM32 core based on ST HAL automation moved this from Done to In progress Mar 25, 2024
@fpistm fpistm self-requested a review March 25, 2024 15:33
fpistm
fpistm approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

STM32 core based on ST HAL automation moved this from In progress to Reviewer approved Mar 25, 2024
@fpistm fpistm merged commit 79579d7 into stm32duino:main Mar 26, 2024
46 checks passed
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Mar 26, 2024
tadtruex pushed a commit to TadAtThayer/Arduino_Core_STM32 that referenced this pull request Apr 23, 2024
@VirensCn @tadtruex
feat: add "toString" function to IPAddress (stm32duino#2306)
baa6c67 
Signed-off-by: Virens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
arduino compatibility enhancement New feature or request
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

IPAddress is missing the toString function interface？
2 participants
@VirensCn @fpistm