Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for ELV-BM-TRX1 #2373

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

ELV-Elektronik-AG
Copy link

@ELV-Elektronik-AG ELV-Elektronik-AG commented May 22, 2024

  • Added Support for the ELV-BM-TRX1

The ELV Modular System is a great fit for the stm32duino library

Validation

Github Actions have passed, a working sketch is

#include "STM32LowPower.h"

void setup() {
  pinMode(LED_BUILTIN, OUTPUT);
  // Configure low power
  LowPower.begin();
}

void loop() {
  digitalWrite(LED_BUILTIN, HIGH);
  LowPower.deepSleep(1000);
  digitalWrite(LED_BUILTIN, LOW);
  LowPower.deepSleep(1000);
}

@fpistm fpistm added the new variant Add support of new bard label May 23, 2024
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation May 23, 2024
@fpistm fpistm added this to the 2.8.0 milestone May 23, 2024
@fpistm fpistm self-requested a review May 23, 2024 08:40
@fpistm
Copy link
Member

fpistm commented May 23, 2024

Hi @ELV-Elektronik-AG
I've made some change on your PR. (Note: as a good practice I advise to not use main branch name for a PR).
I've removed all commented code, fix some change in the README.d not link to the PR and fixed the boards.txt.
Anyway I've some other questions I will raised in the review.

STM32 core based on ST HAL automation moved this from In progress to Needs review May 23, 2024
boards.txt Outdated Show resolved Hide resolved
@fpistm fpistm requested a review from fabry1992 May 23, 2024 12:50
@fpistm
Copy link
Member

fpistm commented May 23, 2024

@fabry1992
you can't approve it as no change has been done since my last review.
Let me update with your input and then you can test on your side.

Stephan Fabry and others added 2 commits May 23, 2024 16:33
Signed-off-by: Stephan Fabry <[email protected]>
Co-Authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
@fpistm
Copy link
Member

fpistm commented May 23, 2024

@ELV-Elektronik-AG, @fabry1992
I've made the full update, forced pushed on your branch and resolved all conversations.
Please fetch your main branch to get the latest update and check if it is ok.

@fpistm fpistm requested review from fabry1992 and fpistm May 23, 2024 14:39
Copy link

@fabry1992 fabry1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hvae tested The pins and everything works. Thanks so much for your work and im sorry to be suc a nuisance

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved May 24, 2024
@fpistm
Copy link
Member

fpistm commented May 24, 2024

Hi @fabry1992

I hvae tested The pins and everything works. Thanks so much for your work and im sorry to be suc a nuisance

No worry. Thanks for the test. From my side it is ok to merge. Are you ok?

@fpistm fpistm merged commit 36fb912 into stm32duino:main May 27, 2024
24 checks passed
STM32 core based on ST HAL automation moved this from Reviewer approved to Done May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants