Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACM-15128 networking options support for node pools HCP cluster #4183

Merged
merged 41 commits into from
Jan 22, 2025
Merged

ACM-15128 networking options support for node pools HCP cluster #4183

merged 41 commits into from
Jan 22, 2025

Conversation

vishsanghishetty
Copy link
Contributor

@vishsanghishetty vishsanghishetty commented Jan 8, 2025 •
edited
Loading

Description

OpenShift Virtualization wizard supports networking options for node pools

This PR is for ticket

Acceptance Criteria

  • Feature Addition: Introduced the ability to define additional networks for each node pool in the format <namespace>/<name>
  • Each node pool maintains its list of additional networks, enabling independent and specific configurations.
  • Attach default pod network checkbox - checked and disabled when there are no additional networks
  • Unit tests

@vishsanghishetty

This comment was marked as outdated.

Sign in to view
@vishsanghishetty

This comment was marked as outdated.

Sign in to view
@vishsanghishetty

This comment was marked as outdated.

Sign in to view
@vishsanghishetty

This comment was marked as duplicate.

Sign in to view
@vishsanghishetty

This comment was marked as duplicate.

Sign in to view
@vishsanghishetty
addresses sonar issues
ad5e451 
Signed-off-by: vsanghishetty <[email protected]>
@vishsanghishetty
Copy link
Contributor Author

/retest

1 similar comment
@vishsanghishetty
Copy link
Contributor Author

/retest

KevinFCormier

This comment was marked as outdated.

Sign in to view

@vishsanghishetty
Copy link
Contributor Author

@KevinFCormier thanks for taking a look. I will work on fixing the above.

@vishsanghishetty

This comment was marked as resolved.

Sign in to view
@vishsanghishetty
Copy link
Contributor Author

/retest

@vishsanghishetty
updates translations
ec03290 
Signed-off-by: vsanghishetty <[email protected]>
@vishsanghishetty
updates initialize control data
7c2a539 
Signed-off-by: vsanghishetty <[email protected]>
@vishsanghishetty
prettier fix
4f3ff8d 
Signed-off-by: vsanghishetty <[email protected]>
@vishsanghishetty
updates translations
ee0f1f1 
Signed-off-by: vsanghishetty <[email protected]>
@vishsanghishetty
updates translations and Kevin's suggestions
2bf6d74 
Signed-off-by: vsanghishetty <[email protected]>
@vishsanghishetty vishsanghishetty force-pushed the ACM-15128-nodepools-networking-options-support-hcp-cluster branch from 52c80bf to 2bf6d74 Compare January 22, 2025 11:11
@KevinFCormier
Copy link
Contributor

/hold for QE capacity

@KevinFCormier
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 22, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, vishsanghishetty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KevinFCormier,vishsanghishetty]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KevinFCormier
Copy link
Contributor

/unhold

@KevinFCormier
Copy link
Contributor

/override "Red Hat Konflux / acm-213-enterprise-contract-registry-standard / console-acm-213"

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 22, 2025

@KevinFCormier: Overrode contexts on behalf of KevinFCormier: Red Hat Konflux / acm-213-enterprise-contract-registry-standard / console-acm-213

In response to this:

/override "Red Hat Konflux / acm-213-enterprise-contract-registry-standard / console-acm-213"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@KevinFCormier
Copy link
Contributor

/override "Red Hat Konflux / mce-28-enterprise-contract-registry-standard / console-mce-mce-28"

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 22, 2025

@KevinFCormier: Overrode contexts on behalf of KevinFCormier: Red Hat Konflux / mce-28-enterprise-contract-registry-standard / console-mce-mce-28

In response to this:

/override "Red Hat Konflux / mce-28-enterprise-contract-registry-standard / console-mce-mce-28"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
74.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@openshift-merge-bot openshift-merge-bot bot merged commit af442b9 into stolostron:main Jan 22, 2025
11 of 13 checks passed
vishsanghishetty added a commit that referenced this pull request Jan 22, 2025
@vishsanghishetty
Revert "ACM-15128 networking options support for node pools HCP clust…
79435ae 
…er (#4183)"

This reverts commit af442b9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oafischer oafischer Awaiting requested review from oafischer

@KevinFCormier KevinFCormier Awaiting requested review from KevinFCormier

Assignees

@KevinFCormier KevinFCormier

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishsanghishetty @KevinFCormier @oafischer