Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP [ACM-17420] Add ACM Searchbar to VM page for filtering #4308

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

WIP [ACM-17420] Add ACM Searchbar to VM page for filtering #4308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
501c531
[ACM-17420] Add ACM Searchbar to VM page for filtering
zlayne Mar 4, 2025
4ece518
Remove table searchbox & fix search result reduce logic
zlayne Mar 5, 2025
934306a
merge main into feature branch
zlayne Mar 11, 2025
15b200a
update unit tests & snapshot
zlayne Mar 11, 2025
b25bfa9
Fix existing vm unit tests
zlayne Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 42 additions & 4 deletions frontend/src/routes/Infrastructure/VirtualMachines/VirtualMachinesPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ import { MemoryRouter } from 'react-router-dom-v5-compat'
import { RecoilRoot } from 'recoil'
import { searchOperatorState } from '../../../atoms'
import { nockPostRequest } from '../../../lib/nock-util'
import { defaultPlugin, PluginContext } from '../../../lib/PluginContext'
import { wait, waitForNocks } from '../../../lib/test-util'
import { ActionExtensionProps, ListColumnExtensionProps } from '../../../plugin-extensions/properties'
import { AcmExtension } from '../../../plugin-extensions/types'
import { SearchOperator } from '../../../resources'
import { SearchResultItemsDocument } from '../../Search/search-sdk/search-sdk'
import { SearchResultItemsDocument, SearchSchemaDocument } from '../../Search/search-sdk/search-sdk'
import VirtualMachinesPage from './VirtualMachinesPage'
import { AcmExtension } from '../../../plugin-extensions/types'
import { defaultPlugin, PluginContext } from '../../../lib/PluginContext'
import { ActionExtensionProps, ListColumnExtensionProps } from '../../../plugin-extensions/properties'

const mockHealthySearchOperator: SearchOperator = {
apiVersion: 'search.open-cluster-management.io/v1alpha1',
Expand Down Expand Up @@ -120,6 +120,25 @@ describe('VirtualMachinesPage Page', () => {
it('should render page with correct vm data', async () => {
const metricNock = nockPostRequest('/metrics?virtual-machines', {})
const mocks = [
{
request: {
query: SearchSchemaDocument,
variables: {
query: {
filters: [{ property: 'kind', values: ['VirtualMachine', 'VirtualMachineInstance'] }],
keywords: [],
limit: 10000,
},
},
},
result: {
data: {
searchSchema: {
allProperties: ['cluster', 'kind', 'label', 'name', 'namespace'],
},
},
},
},
{
request: {
query: SearchResultItemsDocument,
Expand Down Expand Up @@ -298,6 +317,25 @@ describe('VirtualMachinesPage Page', () => {
it('should render page with errors', async () => {
const metricNock = nockPostRequest('/metrics?virtual-machines', {})
const mocks = [
{
request: {
query: SearchSchemaDocument,
variables: {
query: {
filters: [{ property: 'kind', values: ['VirtualMachine', 'VirtualMachineInstance'] }],
keywords: [],
limit: 10000,
},
},
},
result: {
data: {
searchSchema: {
allProperties: ['cluster', 'kind', 'label', 'name', 'namespace'],
},
},
},
},
{
request: {
query: SearchResultItemsDocument,
Expand Down
Loading