PlacementRule ==> Placement

[dhaiducek]

Replaces all PlacementRule with Placement, preparing for its pending removal.

ref: https://issues.redhat.com/browse/ACM-16843

[dhaiducek]

The addon controller flows have a placement controller running but didn't have any name label. This PR resolves it:

• Seed name ManagedCluster label open-cluster-management-io/governance-policy-addon-controller#190

[dhaiducek]

/retest

Network error:

 • [FAILED] [29.282 seconds]
GRC: [P1][Sev1][policy-grc] Test the policy-certificate policy [AfterAll] stable/policy-certificate should be NonCompliant [policy-collection, stable, BVT]
  [AfterAll] /go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_certificate_test.go:149
  [It] /go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_certificate_test.go:140
  [FAILED] Unexpected error:
...
      Delete "https://api.policy-grc-cp-prow-mjxdz.dev08.red-chesterfield.com:6443/api/v1/namespaces/policy-certificate": read tcp 10.128.124.123:57486->3.93.210.3:6443: read: connection reset by peer
...
  occurred
  In [AfterAll] at: /go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_certificate_test.go:160 @ 01/05/25 03:09:53.956 

[dhaiducek]

/retest

Operator flake:

 GRC: [P1][Sev1][policy-grc] Test install Operator When all defaults are used on the subscription test-op-47229 should be created and become compliant [BVT]
/go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:513
  STEP: Verifying that the policy policy-test/test-op-47229 is Compliant @ 01/06/25 21:26:52.833
  [FAILED] in [It] - /go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:517 @ 01/06/25 21:28:52.834
  STEP: Cleaning up the operator installation @ 01/06/25 21:28:52.834
  STEP: Verifying that the policy policy-test/cleanup-grcqeoptest-ns is Compliant @ 01/06/25 21:28:53.076
• [FAILED] [121.490 seconds]
GRC: [P1][Sev1][policy-grc] Test install Operator When all defaults are used on the subscription [It] test-op-47229 should be created and become compliant [BVT]
/go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:513
  [FAILED] Timed out after 120.000s.
  The function passed to Eventually failed at /go/src/github.com/stolostron/governance-policy-framework/test/integration/utils_test.go:53 with:
  Expected
      <string>: NonCompliant
  to equal
      <string>: Compliant
  In [It] at: /go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:517 @ 01/06/25 21:28:52.834 

[dhaiducek]

/retest

(Same OperatorPolicy failure)

[openshift-ci]

@dhaiducek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/test-e2e-grc-framework	1cd8cb4	link	true	/test test-e2e-grc-framework

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dhaiducek]

I suspect this failure is related to changes in this PR since the policy didn't appear to get propagated, so I'll have to put a pause on this until I can run that test a couple times to see what the issue might be:

 • [FAILED] [60.848 seconds]
GRC: [P1][Sev1][policy-grc] Test hub template variables A single-value lookup should work [It] mclabels-fromcm-pol should be created on the Hub [BVT]
/go/src/github.com/stolostron/governance-policy-framework/test/integration/hubtemplates_variables_test.go:32
  [FAILED] Timed out after 60.001s.
  Unexpected error:
      policies.policy.open-cluster-management.io "policy-test.mclabels-fromcm-pol" not found
  occurred
  In [It] at: /go/src/github.com/stolostron/governance-policy-framework/test/integration/hubtemplates_variables_test.go:33 @ 01/07/25 01:23:59.855 

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dhaiducek,yiraeChristineKim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yiraeChristineKim]

I suspect this failure is related to changes in this PR since the policy didn't appear to get propagated, so I'll have to put a pause on this until I can run that test a couple times to see what the issue might be:

 • [FAILED] [60.848 seconds]
GRC: [P1][Sev1][policy-grc] Test hub template variables A single-value lookup should work [It] mclabels-fromcm-pol should be created on the Hub [BVT]
/go/src/github.com/stolostron/governance-policy-framework/test/integration/hubtemplates_variables_test.go:32
  [FAILED] Timed out after 60.001s.
  Unexpected error:
      policies.policy.open-cluster-management.io "policy-test.mclabels-fromcm-pol" not found
  occurred
  In [It] at: /go/src/github.com/stolostron/governance-policy-framework/test/integration/hubtemplates_variables_test.go:33 @ 01/07/25 01:23:59.855 

"Operator flake" passed?

[dhaiducek]

"Operator flake" passed?

Not for this one--it failed at the first test, but the Operator flake did pass at least one time in one of these runs.