Remove deprecated KubeAPIServer config fields#542
Remove deprecated KubeAPIServer config fields#542xuezhaojun wants to merge 2 commits intostolostron:mainfrom
Conversation
The use of context.TODO() is generally discouraged in production code as it should only be used when it's unclear which context to use. In this case, we have a proper context available from the StartReconcileFlightCtlResources function parameter. This change improves code quality by: 1. Using the proper context that can be cancelled when the manager stops 2. Following Go best practices for context propagation 3. Making the code more maintainable by removing temporary solutions Signed-off-by: xuezhaojun <zxue@redhat.com>
Remove deprecated HubKubeAPIServerURL and HubKubeAPIServerCABundle fields in favor of using HubKubeAPIServerConfig. Update error messages to be more specific about the required configuration. Signed-off-by: xuezhaojun <zxue@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@xuezhaojun: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
1 participant
What this PR does
This PR removes deprecated code paths in the bootstrap package that were using the old
HubKubeAPIServerURLandHubKubeAPIServerCABundlefields. These fields have been superseded by theHubKubeAPIServerConfigstructure.Changes
HubKubeAPIServerURLandHubKubeAPIServerCABundleHubKubeAPIServerConfigWhy this PR is needed
This change improves code maintainability by removing deprecated code paths and making error messages more helpful for users configuring the hub KubeAPIServer.