-
Notifications
You must be signed in to change notification settings - Fork 9
Add manifests to enable metrics-collector running independently #36
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: clyang82 <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks good to me! One question - can you determine the ClusterID from the command-line via |
updated in description. |
Signed-off-by: clyang82 <[email protected]>
/assign @haoqing0110 |
Kudos, SonarCloud Quality Gate passed! |
Just one concern is, we also have a depoloyment in https://github.com/open-cluster-management/metrics-collector/blob/main/test/integration/manifests/deployment.yaml. Is that possible to only maintain one? |
👍 Yes. I did not realize we have it in integration folder. Let me update it in integration folder. |
Right now, it is hardcoded for openshift. If you want to have it worked in *KS, you need to update
|
Sorry for the sluggish reply - we're just now scheduling this task - what modification would we need to make to these values to support *KS? |
https://github.com/open-cluster-management/backlog/issues/11875
Have this PR to enable running metrics-collector independently.
You need to replace the following variable before applying to an environment:
${CLUSTER_NAME}
to your cluster name${CLUSTER_ID}
you can get byoc get clusterversions -o jsonpath="{.items[0].spec.clusterID}"
${OBSERVATORIUM_RECEIVER_URL}
is your hub cluster you want to push metrics. You can get the observatorium route api by runningoc get route -n open-cluster-management-observability observatorium-api
and append/api/metrics/v1/default/api/v1/receive
to form the final url.${CA_CRT}
${TLS_CRT}
${TLS_KEY}
are used to authenticate with observatorium api. You can get the content by running in your hub clusteroc get secret -n open-cluster-management-addon-observability observability-managed-cluster-certs -oyaml
.${METRICS_COLLECTOR_IMAGE}
to point metrics-collector image. e.g.:quay.io/open-cluster-management/metrics-collector:2.3.0-SNAPSHOT-2021-06-08-08-29-28
Signed-off-by: clyang82 [email protected]