Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Deploy agent via global hub operator #1202

Merged
merged 9 commits into from
Jan 16, 2025

Conversation

clyang82
Copy link
Contributor

@clyang82 clyang82 commented Nov 6, 2024

Summary

Deploy agent via global hub operator

Related issue(s)

Fixes # https://issues.redhat.com/browse/ACM-17113

Tests

  • Unit/function tests have been added and incorporated into make unit-tests.
  • Integration tests have been added and incorporated into make integration-test.
  • E2E tests have been added and incorporated into make e2e-test-all.
  • List other manual tests you have done.
  • manually check the operator to create the agent
multicluster-global-hub-agent-69cb8db8cc-th2bs      1/1     Running   0          66s
multicluster-global-hub-operator-547484b99f-t4tvm   1/1     Running   0          113s

Copy link

openshift-ci bot commented Nov 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@clyang82 clyang82 force-pushed the deploy_agent branch 3 times, most recently from baac57a to 10e3458 Compare January 14, 2025 12:06
Signed-off-by: clyang82 <[email protected]>
@ldpliu
Copy link
Contributor

ldpliu commented Jan 16, 2025

it's ok for me.

@yanmxa
Copy link
Member

yanmxa commented Jan 16, 2025

/LGTM

Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82
Copy link
Contributor Author

/retest

1 similar comment
@clyang82
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit ee7c8ea into stolostron:main Jan 16, 2025
14 checks passed
@clyang82 clyang82 deleted the deploy_agent branch January 17, 2025 01:28
yanmxa pushed a commit to yanmxa/hub-of-hubs that referenced this pull request Jan 20, 2025
* Support deploy standalone agent via operator

Signed-off-by: clyang82 <[email protected]>

* Register standalone controller

Signed-off-by: clyang82 <[email protected]>

* trigger reconciler

Signed-off-by: clyang82 <[email protected]>

* Give watch;list permissions

Signed-off-by: clyang82 <[email protected]>

* Remove redundant permissions

Signed-off-by: clyang82 <[email protected]>

* Add apps.open-cluster-management.io permissions

Signed-off-by: clyang82 <[email protected]>

* Update the instruction

Signed-off-by: clyang82 <[email protected]>

* Update the instruction

Signed-off-by: clyang82 <[email protected]>

* Update the sample

Signed-off-by: clyang82 <[email protected]>

---------

Signed-off-by: clyang82 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants