WIP: allow reconcile on storage size changes #1651
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coleenquadros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test test-e2e |
| @@ -75,6 +75,8 @@ printf "\n baseDomain: ${base_domain}" >>${OPTIONSFILE} | |||
| printf "\n kubeconfig: ${kubeconfig_hub_path}" >>${OPTIONSFILE} | |||
| printf "\n kubecontext: ${kubecontext}" >>${OPTIONSFILE} | |||
|
|
|||
|
|
|||
|
|
|||
| @@ -234,6 +260,7 @@ wait_for_deployment_ready() { | |||
| # function execute is the main routine to do the actual work | |||
| execute() { | |||
| deploy_hub_spoke_core | |||
| deploy_managed_cluster | |||
There was a problem hiding this comment.
The managed cluster tests are great! But should be a separate PR.
| log.Info("Coleen Old observatorium CR spec", "oldSpec", oldSpec) | ||
| log.Info("Coleen New observatorium CR spec", "newSpec", newSpec) | ||
|
|
There was a problem hiding this comment.
Was this intended to be merged?
| return *result, err | ||
| } | ||
|
|
||
| // generate grafana datasource to point to observatorium api gateway | ||
| result, err = GenerateGrafanaDataSource(r.Client, r.Scheme, instance) | ||
| if result != nil { | ||
| if err != nil { |
There was a problem hiding this comment.
Is this the fix? Only returning if we have a nil error?
moadz
changed the title
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
coleenquadros
force-pushed
the
fix_reconcile
branch
from
51162b8 to
328bd1c
Compare
Signed-off-by: Coleen Iona Quadros <[email protected]>
|
|
@coleenquadros: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.