Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update switch-to-grafana-admin.sh #1683

Closed
wants to merge 3 commits into from
Closed

Conversation

ch-stark
Copy link

as discussed with Subbarao

Copy link
Collaborator

@subbarao-meduri subbarao-meduri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ch-stark, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jan 10, 2025

New changes are detected. LGTM label has been removed.

thibaultmg and others added 2 commits January 10, 2025 18:27
* fix staus update and cm predicate

Signed-off-by: Thibault Mange <[email protected]>

* fix invalid update branching

Signed-off-by: Thibault Mange <[email protected]>

---------

Signed-off-by: Thibault Mange <[email protected]>
Signed-off-by: Christian Stark <[email protected]>
Signed-off-by: Christian Stark <[email protected]>
@ch-stark ch-stark closed this Jan 10, 2025
@ch-stark
Copy link
Author

do not get it to work, will create new pr with commit signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants