Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cron validation prop #1916

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

birsanv
Copy link
Contributor

@birsanv birsanv commented Jan 14, 2025

Description

Update cron job validation prop

Related Issue

https://issues.redhat.com/browse/ACM-16218

Changes Made

Updates backup policy cron job validation property and use just the name of the vm with an invalid cron job, to avoid errors when the strings is longer than the allowed 64 char

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Valentina Birsan <[email protected]>
Signed-off-by: Valentina Birsan <[email protected]>
@birsanv
Copy link
Contributor Author

birsanv commented Jan 14, 2025

/assign @dislbenn

@dislbenn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 14, 2025
Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, dislbenn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 97fd2d0 into stolostron:main Jan 14, 2025
10 checks passed
@birsanv birsanv deleted the vb_dpa_spec branch January 14, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants