Enable hermetic builds #380
Conversation
dhaiducek
force-pushed
the
dhaiduce-main-hermetic
branch
10 times, most recently
from
4826919 to
8782f66
Compare
dhaiducek
force-pushed
the
dhaiduce-main-hermetic
branch
2 times, most recently
from
56e32cd to
2bbe563
Compare
Signed-off-by: Dale Haiducek <[email protected]>
Signed-off-by: Dale Haiducek <[email protected]>
dhaiducek
force-pushed
the
dhaiduce-main-hermetic
branch
from
2bbe563 to
4e0ec67
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
| @@ -134,24 +134,29 @@ if [ -z $GATHER_MCE_RAN ] || [ $GATHER_MCE_RAN != true ]; then | |||
| } | |||
|
|
|||
| gather_service_and_event_logs_for_failed_agents() { | |||
There was a problem hiding this comment.
@paul-maidment You were the author of the original code, so I wanted to get some feedback on this change we just merged. I'm not sure this block had been working since it leveraged yq, which isn't readily available as an RPM. I've re-flowed it in this PR to use jq with an oc get call instead. If you have a moment (and/or have a cluster you can send me via Slack to test it out), I'd appreciate if you'd verify the logic here. Thanks!
No description provided.