-
Notifications
You must be signed in to change notification settings - Fork 245
Fix description for allOf-inheriting child schemas #2818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@darekplawecki we would appreciated if you or someone else from your team would consider merging this, thanks. |
@marcelstoer Apologies for the late reply. We have been busy with some other priorities. We'll review this, this week! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to release it, make sure you bump up versions in proper package.json files. Here's the versioning guideline to follow.
I had studied the versioning guide prior to creating the PR. However, it wasn't clear to me whether I need to bump the version with every single PR i.e. whether each commit to |
@darekplawecki while reviewing the release automation I found and fixed #2826. |
e90d5e5
to
375fa32
Compare
375fa32
to
b35d522
Compare
@darekplawecki allow one question: whose job is it to eventually merge the PRs after you approved them? |
Fixes #2810
Elements Default PR Template
In general, make sure you have: (check the boxes to acknowledge you've followed this template)
CONTRIBUTING.md
Other Available PR Templates:
CONTRIBUTING.md