Skip to content

Conversation

marcelstoer
Copy link

@marcelstoer marcelstoer commented Jul 15, 2025

Fixes #2810

Elements Default PR Template

In general, make sure you have: (check the boxes to acknowledge you've followed this template)

Other Available PR Templates:

@marcelstoer marcelstoer requested a review from a team as a code owner July 15, 2025 13:22
Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit b35d522
🔍 Latest deploy log https://app.netlify.com/projects/stoplight-elements/deploys/6893130d66ab95000890ec68
😎 Deploy Preview https://deploy-preview-2818--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit b35d522
🔍 Latest deploy log https://app.netlify.com/projects/stoplight-elements-demo/deploys/6893130da16f600008562570
😎 Deploy Preview https://deploy-preview-2818--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@marcelstoer
Copy link
Author

@darekplawecki we would appreciated if you or someone else from your team would consider merging this, thanks.

@mnaumanali94
Copy link
Contributor

@marcelstoer Apologies for the late reply. We have been busy with some other priorities. We'll review this, this week!

Copy link
Contributor

@darekplawecki darekplawecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to release it, make sure you bump up versions in proper package.json files. Here's the versioning guideline to follow.

@marcelstoer
Copy link
Author

I had studied the versioning guide prior to creating the PR. However, it wasn't clear to me whether I need to bump the version with every single PR i.e. whether each commit to main will trigger a new release. I now realized you have automation in place for that.
→ I'll bump the versions

@marcelstoer
Copy link
Author

@darekplawecki while reviewing the release automation I found and fixed #2826.

@marcelstoer marcelstoer force-pushed the fix/schema-description branch from e90d5e5 to 375fa32 Compare August 6, 2025 08:29
@marcelstoer marcelstoer force-pushed the fix/schema-description branch from 375fa32 to b35d522 Compare August 6, 2025 08:32
@marcelstoer
Copy link
Author

@darekplawecki allow one question: whose job is it to eventually merge the PRs after you approved them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allOf-child schema description missing
3 participants