fix: circular reference issue resolved #2538
Conversation
SB-rohitdesai
requested review from
kaylachun,
rainum and
mnaumanali94
and removed request for
a team
SB-rohitdesai
changed the title
|
is this supposed to include a version of json-schema-ref-parser that has your optimization changes in it? stoplightio/json-schema-ref-parser#62 in it? |
Test case added |
Not required. currently we just merging this PR only |
| @@ -676,5 +689,31 @@ describe('mocker', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('should return 500 error', () => { | |||
There was a problem hiding this comment.
This test does not seem relevant to this PR. Could you please add a test that covers the original circular reference problem and show that it is no longer throwing a 500?
| }); | ||
| }); | ||
|
|
||
| describe('With __bundled__ should get response', () => { |
There was a problem hiding this comment.
This test is passing with and without your changes so it still doesn't seem to be testing the initial bug you were seeing / the fix hasn't changed anything. It should be removed or changed to properly capture the issue you are seeing and fixing.
We have test harness tests for circular references and those have been passing in the pipeline so it seems like circular references are getting resolved in most cases. Maybe a test harness test for the specific scenario that is causing you not to see circular references get resolved would help demonstrate the issue a bit better.
Mock server not working In case of circular references
Summary
Getting 500 Error or Sometimes might need to wait a long time before getting this error when spec having circular references
Checklist