Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tell users when they have unrecoverable spaces #67

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

travis
Copy link
Contributor

@travis travis commented Dec 12, 2023

Use a heuristic to look at available claims and determine whether a space is recoverable. Currently considers a space recoverable if any abilities are delegated and should probably validate a minimum set.

Unfortunately we don't have any way for users to recover an "unrecoverable" space at the moment, since we still discard Space keys after creation - I'm not convinced this feature is particularly helpful without some way to fix unrecoverable spaces, but it is probably better than not having any way to determine that at all!

Screenshot 2023-12-11 at 5 02 31 PM Screenshot 2023-12-11 at 5 02 47 PM

Use a heuristic to look at available claims and determine whether a space is recoverable. Currently considers a space recoverable if any abilities are delegated and should probably validate a minimum set.

Unfortunately we don't have any way for users to recover an "unrecoverable" space at the moment, since we still discard Space keys after creation - I'm not convinced this feature is particularly helpful without some way to fix unrecoverable spaces, but it is probably better than not having any way to determine that at all!
@travis travis changed the title wip: tell users when they have unrecoverable spaces feat: tell users when they have unrecoverable spaces Dec 12, 2023
Copy link
Contributor

Website preview 🔗✨

build log

@alanshaw
Copy link
Member

I really like the UI...but without some actionable thing I'm not sure it's worth adding.

I'm not sure I understand why guessRecoverableCapabilities is a "guess"?

How can you have a space without any capabilities?

@travis
Copy link
Contributor Author

travis commented Dec 13, 2023

I'm not sure I understand why guessRecoverableCapabilities is a "guess"?

So, right now it just looks to see if you have any capabilities, when it should probably verify that you either have * or a minimum set of capabilities - store/add and upload/add maybe? I think we could stop calling it a guess if we had a formally specified minimum set of capabilities that constituted "space posession"

How can you have a space without any capabilities?

Hm good point - I think the too-simple answer is that the || [] https://github.com/web3-storage/console/pull/67/files#diff-73d7a23e5015801b9bcc9db601d6ec9594d3eb34e5bb23154e0ae4b0c30f1a3bR64 will make it look like you have a space with no capabilities if the delegations you've just claimed don't include the space you're rendering.

This can happen when you have a space saved in your local delegation store that does not have a recovery delegation. We'll render spaces based on what you have locally, and will sometimes not be able to find a corresponding delegation in the claim result. I don't think the current API does a great job of making this clear, will keep thinking about it and would welcome any ideas for improvement for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants