feat!: collapse all clients into one #1078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
commented
Nov 7, 2023
Comment on lines
27
to
45
| ".": { | ||
| "types": "./dist/src/index.d.ts", | ||
| "import": "./src/index.js" | ||
| }, | ||
| "./aggregator": { | ||
| "types": "./dist/src/aggregator.d.ts", | ||
| "import": "./src/aggregator.js" | ||
| }, | ||
| "./dealer": { | ||
| "types": "./dist/src/dealer.d.ts", | ||
| "import": "./src/dealer.js" | ||
| }, | ||
| "./storefront": { | ||
| "types": "./dist/src/storefront.d.ts", | ||
| "import": "./src/storefront.js" | ||
| }, | ||
| "./types": { | ||
| "types": "./dist/src/types.d.ts", | ||
| "import": "./src/types.js" |
There was a problem hiding this comment.
@vasco-santos is this change ok ? Not sure why we painted to dist but that caused TS to fail because it was resolving to files that were not there yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collapses all clients into a single w3up-client
For backwards compatibility access-client and upload-client simply re-export their former modules which they import from the w3up-client. Please note that I have not done any real cleanup here simply moved files around, we can clean things up in the future.
I think we can release these versions on npm and then deprecate them and remove from the repo.