feat!: deprecate issuer #1344
Merged
feat!: deprecate issuer #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
force-pushed
the
feat/deprecate-issuer
branch
from
f06dfde
to
fe9ef4e
Compare
This was referenced Mar 26, 2024
vasco-santos
approved these changes
Mar 26, 2024
Gozala
added a commit
to storacha-network/w3infra
that referenced
this pull request
Apr 23, 2024
alanshaw
approved these changes
May 13, 2024
| * @deprecated - Issuer of the invocation is irrelevant as long as | ||
| * they have authorization to invoke on subject `space`. | ||
| */ | ||
| issuer?: DID |
There was a problem hiding this comment.
Ideally we'd like tracability with a cause field but probably not so bad now we're moving to blob protocol.
There was a problem hiding this comment.
that would be the invocation right?
There was a problem hiding this comment.
Oh, yeah I'm getting mixed up with the upload table. Ignore me!
Gozala
added a commit
that referenced
this pull request
May 13, 2024
This is based on #1344 and it stops passing issuer when inserting into a table. I wanted to make this a separate PR so we can update w3infra first and remove field there and then stop passing here.
travis
added a commit
that referenced
this pull request
May 14, 2024
🤖 I have created a release *beep* *boop* --- ## [14.0.0](upload-api-v13.0.2...upload-api-v14.0.0) (2024-05-14) ### ⚠ BREAKING CHANGES * deprecate issuer ([#1344](#1344)) ### Features * add "plan/create-admin-session" capability ([#1411](#1411)) ([50eeeb5](50eeeb5)) * add blob protocol to upload-client ([#1425](#1425)) ([49aef56](49aef56)) * deprecate issuer ([#1344](#1344)) ([afbbde3](afbbde3)) * move blob index logic from upload-api to blob-index lib ([#1434](#1434)) ([797f628](797f628)) * remove issuer row ([#1345](#1345)) ([cf5b0db](cf5b0db)) ### Fixes * `encodeURIComponent` on bucket origin ([#1448](#1448)) ([5618644](5618644)) * add format specifier to blob location claim URL ([#1445](#1445)) ([9982d12](9982d12)) * test against actual api ([#1438](#1438)) ([f8132ca](f8132ca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1339 (comment) this PR deprecates
issuerfield from table record.