fix: share space via ucan file #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Website preview 🔗✨ |
fforbeck
force-pushed
the
shared-space-did
branch
from
4609981
to
8a4fdc7
Compare
fforbeck
force-pushed
the
shared-space-did
branch
from
8a4fdc7
to
05a88fc
Compare
alanshaw
approved these changes
Sep 23, 2024
fforbeck
force-pushed
the
share-spaces
branch
5 times, most recently
from
8859ae4
to
9bbcd5b
Compare
fforbeck
force-pushed
the
shared-space-did
branch
from
05a88fc
to
d72ffbb
Compare
fforbeck
pushed a commit
that referenced
this pull request
Sep 24, 2024
🤖 I have created a release *beep* *boop* --- ## [1.11.0](w3console-v1.10.0...w3console-v1.11.0) (2024-09-24) ### Features * share spaces via email ([#123](#123)) ([896079b](896079b)) ### Bug Fixes * import space preview ([#127](#127)) ([1f2acf6](1f2acf6)) * share space via ucan file ([#126](#126)) ([ba934a2](ba934a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issues
The issue happens when we try to delegate
*to the DID of the audience. I've updated the code to delegate the same capabilities we use in theclient.shareSpacemethod.