Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import space preview #127

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: import space preview #127

merged 1 commit into from
Sep 24, 2024

Conversation

fforbeck
Copy link
Member

Fixes: #94

When you import an Space from the UCAN file it generates several components as Space Preview:
Screenshot from 2024-09-20 15-44-05

Ideally, it would render only one component for the Space that was imported:
Screenshot from 2024-09-23 11-02-22

This PR fixes that component and includes the information icon to show the capabilities delegated to that shared Space.

Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from shared-space-did to main September 24, 2024 14:11
Copy link
Contributor

@fforbeck fforbeck merged commit 1f2acf6 into main Sep 24, 2024
5 checks passed
@fforbeck fforbeck deleted the fix-import-ucan branch September 24, 2024 14:17
fforbeck pushed a commit that referenced this pull request Sep 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.11.0](w3console-v1.10.0...w3console-v1.11.0)
(2024-09-24)


### Features

* share spaces via email
([#123](#123))
([896079b](896079b))


### Bug Fixes

* import space preview
([#127](#127))
([1f2acf6](1f2acf6))
* share space via ucan file
([#126](#126))
([ba934a2](ba934a2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when importing a space, it works but I see the same space DID listed many times with many named 'untitled'
2 participants