Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(capability): add space to location assertion #84

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hannahhoward
Copy link
Member

@hannahhoward hannahhoward commented Jan 16, 2025

Goals

Enable parsing and usage of assertions defined here with responses from the indexer service.

Implementation

Add Space DID as an optional field for the AssertLocation

For Discussion

Why ship a change here?

This library contains the best JS definitions of our various assertions. Apart from the missing Space DID, it's the SAME as the assertions defined in go-capabilities.

Currently, JS fetching logic for the indexer does NOT understand assertions, and moreover, the locator for the indexing service in the blob-fetcher uses a non-standard approach of using a parsing validator called 'zod' to parse only location claims.

We should maintain full definitions for our various assertions across languages and those definitions should maintain parity.

Ultimately, they shouldn't live here. Maybe @storacha/capabilities -- i.e. move them to w3up. But that's a problem for another day.

Copy link

seed-deploy bot commented Jan 16, 2025

View stack outputs

also provides direct access to the delegation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants