feat: validate caveat payloads #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change all references to web3-storage package, move to storacha-network package BREAKING CHANGE: referencing this package at web3-storage will no longer work after this commit
improves the result type with a more functional typed union primitive and useful wrapper functions
# Goals It had to happen sometime... fixing the names before it gets to complicated # Implementation Change all references to web3-storage package, move to storacha-network package BREAKING CHANGE: referencing this package at web3-storage will no longer work after this commit due to the way go.mod works
# Goals A result type with terser, more type safe and functional UX # Implementation I've been working on this for a few days -- just trying to assemble a result type that seems more pleasant to work with cause it follows traditional functional paradigms around typed unions. This also adds a few recovery functions and restores the NewFailure function.
create a much simpler generic interface for rebind and simplify body as well
|
@hannahhoward I merged the |
hannahhoward
approved these changes
Aug 20, 2024
Co-authored-by: hannahhoward <[email protected]> Co-authored-by: Steve Moyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows caveats (nb) to be used in server handler functions.
It adds a minimal validator framework that parses caveats to a Go type.
You can now define a capability with a Go type for caveats (and an IPLD schema). This allows incoming capability invocation payloads to be parsed to check for validity.