Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cbor prepare encode wrongly identifying circular structure #327

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: cbor prepare encode wrongly identifying circular structure #327

merged 1 commit into from
Nov 15, 2023

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Nov 15, 2023 •
edited
Loading

Failing on:

const obj = {}
CBOR.encode({
  a: obj,
  b: obj
})

@vasco-santos vasco-santos changed the title fix: cbor prepare encode wrongly identifying circular sturcture fix: cbor prepare encode wrongly identifying circular structure Nov 15, 2023
@vasco-santos vasco-santos merged commit 3c03c9d into main Nov 15, 2023
38 checks passed
@vasco-santos vasco-santos deleted the fix/cbor-prepare-wrongly-identifying-circular-structure branch November 15, 2023 10:49
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gozala Gozala Gozala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @Gozala