-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import space from base64 string #122
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,8 +11,9 @@ import { | |
checkPathsExist, | ||
filesize, | ||
filesizeMB, | ||
readProof, | ||
uploadListResponseToString, | ||
proofFromString, | ||
proofFromPath | ||
} from './lib.js' | ||
import * as ucanto from '@ucanto/core' | ||
import * as DidMailto from '@web3-storage/did-mailto' | ||
|
@@ -284,11 +285,16 @@ export async function registerSpace(opts) { | |
|
||
/** | ||
* @param {string} proofPath | ||
* @param {object} opts | ||
* @param {string} opts.base64 | ||
*/ | ||
export async function addSpace(proofPath) { | ||
export async function addSpace(proofPath, opts) { | ||
const client = await getClient() | ||
const delegation = await readProof(proofPath) | ||
const space = await client.addSpace(delegation) | ||
const proof = opts.base64 | ||
? await proofFromString(opts.base64) | ||
: await proofFromPath(proofPath) | ||
const space = await client.addSpace(proof) | ||
await client.setCurrentSpace(space.did()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I reckon space add should set the current space. It was annoying to have to do that manually after calling space add. This is what space create does, so this would be consistent. |
||
console.log(space.did()) | ||
} | ||
|
||
|
@@ -445,7 +451,7 @@ export async function revokeDelegation(delegationCid, opts) { | |
let proof | ||
try { | ||
if (opts.proof) { | ||
proof = await readProof(opts.proof) | ||
proof = await proofFromPath(opts.proof) | ||
} | ||
} catch (/** @type {any} */ err) { | ||
console.log(`Error: reading proof: ${err.message}`) | ||
|
@@ -479,7 +485,7 @@ export async function addProof(proofPath, opts) { | |
const client = await getClient() | ||
let proof | ||
try { | ||
proof = await readProof(proofPath) | ||
proof = await proofFromPath(proofPath) | ||
if (!opts?.['dry-run']) { | ||
await client.addProof(proof) | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it would be helpful for noobs to know more about what is expected as the bytes that are base64d. iirc the idea is we accept any UCAN serialization? but esp car files?
(e.g. do you want base64(cidOfProofCar) or base64(proofCarWithDagUcanCbor)) ?