feat: require payment plans to provision spaces #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the heavy lifting here is done by upgrading the `@web3-storage/upload-api` dependency. There is a new "feature flag" in the context that changes whether payment plans are required for provisioning - I'm going to set it to `false` for now in production and we can flip it once we're ready to turn this on. I spent a bit of time working toward extending our integration tests to exercise the Stripe webhook handler, but it turned into a big enough project that I decided to defer and recorded what I learned in an issue here: #267
vasco-santos
approved these changes
Nov 8, 2023
| @@ -38,3 +38,5 @@ SATNAV_BUCKET_NAME = '' | |||
| MAILSLURP_API_KEY = '' | |||
| MAILSLURP_TIMEOUT = '120000' | |||
|
|
|||
| # Feature flags | |||
| REQUIRE_PAYMENT_PLAN = 'true' | |||
There was a problem hiding this comment.
would be good to test this in staging. I am not 100% sure if swapping env var is enough, or we need to re-deploy. So knowing that can help us know what we need to do
View stack outputs
|
alanshaw
approved these changes
Nov 8, 2023
upload-api/test/helpers/ucan.js
Outdated
| @@ -295,6 +295,7 @@ export async function executionContextToUcantoTestServerContext (t) { | |||
|
|
|||
| return { | |||
| ...serviceContext, | |||
| grantAccess: async () => {}, | |||
There was a problem hiding this comment.
Suggested change
| grantAccess: async () => {}, |
There was a problem hiding this comment.
oh lol we were looking at this at precisely the same time - fixed, thx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the heavy lifting here is done by upgrading the
@web3-storage/upload-apidependency. There is a new "feature flag" in the context that changes whether payment plans are required for provisioning - I'm going to set it tofalsefor now in production and we can flip it once we're ready to turn this on.I spent a bit of time working toward extending our integration tests to exercise the Stripe webhook handler, but it turned into a big enough project that I decided to defer and recorded what I learned in an issue here:
#267