Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove console #588

Merged
merged 5 commits into from
Nov 22, 2023
Merged

chore: remove console #588

merged 5 commits into from
Nov 22, 2023

Conversation

alanshaw
Copy link
Member

Console moved to https://github.com/web3-storage/console

w3ui is currently publishing an old version of console to staging @ https://staging.console.web3.storage/

@travis
Copy link
Member

travis commented Nov 21, 2023

There are two big things in this PR:

  1. removing the deployment logic so we don't push this to staging.console.web3.storage
  2. removing the w3console example from the repo

(1) is definitely a good idea, let's ship it asap
re: (2):
I could be convinced here, but I like having this example here as a good full-on example of how to use the components together to create a basic app. Much of the functionality is reproduced in the new standalone console repository, but that is complicated by concerns more specific to our business (ie, billing) and I think it doesn't do as great a job of just showing off how these components can all work together.

I do think it's potentially worth winnowing down the set of examples we provide here, but if we decide to do that I'd consider going the other direction and removing the examples that use each of the components in isolation - I think it's more useful to see them working together than alone.

Definitely hold this opinion pretty lightly, so if you feel strongly about this I can get behind it!

@alanshaw
Copy link
Member Author

Ok yes I think I half agree. Lets defer the decision and just merge the CI changes.

@alanshaw alanshaw merged commit 6f0e626 into main Nov 22, 2023
2 checks passed
@alanshaw alanshaw deleted the chore/remove-console branch November 22, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants