Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: deprecate issuer #1344

Merged
merged 1 commit into from
May 13, 2024
Merged

feat!: deprecate issuer #1344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/upload-api/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,12 @@ export interface StoreAddInput {
link: UnknownLink
size: number
origin?: UnknownLink
issuer: DID

/**
* @deprecated - Issuer of the invocation is irrelevant as long as
* they have authorization to invoke on subject `space`.
*/
issuer?: DID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd like tracability with a cause field but probably not so bad now we're moving to blob protocol.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be the invocation right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah I'm getting mixed up with the upload table. Ignore me!

invocation: UCANLink
}

Expand Down
Loading