fix(test): await promise and check error #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
approved these changes
Oct 14, 2024
fforbeck
added a commit
that referenced
this pull request
Oct 24, 2024
🤖 I have created a release *beep* *boop* --- ## [18.1.0](upload-api-v18.0.3...upload-api-v18.1.0) (2024-10-24) ### Features * Generate Space proofs on the fly, on `access/claim` ([#1555](#1555)) ([9e2b1d4](9e2b1d4)) * usage/record capability definition ([#1562](#1562)) ([98c8a87](98c8a87)) ### Fixes * Error should refer to Resource, not Issuer ([#1558](#1558)) ([25e35e3](25e35e3)) * repo URLs ([#1550](#1550)) ([e02ddf3](e02ddf3)) * **test:** await promise and check error ([#1563](#1563)) ([86e7a46](86e7a46)) ### Other Changes * Add `pnpm dev` to watch-build all packages ([#1533](#1533)) ([07970ef](07970ef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Felipe Forbeck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve ESLint Promise Handling Error
Fixed the ESLint error by using
assert.rejectsto handle the promise returned bydeviceCheater.setCurrentSpace. This ensures that the promise is properly managed and the test checks for expected rejections, addressing the ESLint rule that requires promises to be awaited, handled with.catch, or explicitly ignored.