Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add /reproduce-cloudflare-error route to access-api #380

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Jan 20, 2023

Motivation:

@gobengo gobengo marked this pull request as ready for review January 20, 2023 00:32
@gobengo gobengo temporarily deployed to dev January 20, 2023 00:33 — with GitHub Actions Inactive
Copy link
Contributor

@hugomrdias hugomrdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
we could change the worker from using custom domain binding to the old url pattern binding to check if that fixes the problem.

@gobengo gobengo merged commit edf925f into main Jan 23, 2023
@gobengo gobengo deleted the 1674174432-reproduce-cloudflare-error branch January 23, 2023 17:51
gobengo pushed a commit that referenced this pull request Jan 23, 2023
🤖 I have created a release *beep* *boop*
---


##
[4.8.0](access-api-v4.7.0...access-api-v4.8.0)
(2023-01-23)


### Features

* add /reproduce-cloudflare-error route to access-api
([#380](#380))
([edf925f](edf925f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
gobengo added a commit that referenced this pull request Apr 11, 2023
Motivation:
* cloudflare support asked for a URL to reproduce the undelrying cause
of #363
* this adds a route just for that. once they use it to reproduce and
diagnose, we remove it
gobengo pushed a commit that referenced this pull request Apr 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[4.8.0](access-api-v4.7.0...access-api-v4.8.0)
(2023-01-23)


### Features

* add /reproduce-cloudflare-error route to access-api
([#380](#380))
([0eb3d5f](0eb3d5f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants