Merge pull request #316 from SebbeJohansson/fix/empty-error-value

fix: correctly checks so that error value exists before trying to show one in useAsyncStoryblok
storyblok · Apr 19, 2023 · b6c213a · b6c213a
2 parents 2d4e93d + 6979258
commit b6c213a
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/lib/src/runtime/composables/useAsyncStoryblok.ts b/lib/src/runtime/composables/useAsyncStoryblok.ts
@@ -26,8 +26,8 @@ export const useAsyncStoryblok = async (
     () => storyblokApiInstance.get(`cdn/stories/${url}`, apiOptions),
   );
 
-  if (error.value?.response.status >= 400 && error.value?.response.status < 600) {
-    throw createError({ statusCode: error.value?.response.status, statusMessage: error.value?.message.message });
+  if (error.value?.response && error.value?.response.status >= 400 && error.value?.response.status < 600) {
+    throw createError({ statusCode: error.value?.response.status, statusMessage: error.value?.message?.message || 'Something went wrong when fetching from storyblok.' });
   }
 
   story.value = data.value?.data.story;

diff --git a/playground/pages/[...slug].vue b/playground/pages/[...slug].vue
@@ -0,0 +1,20 @@
+<script setup>
+const route = useRoute();
+
+const story = ref();
+try {
+  story.value = await useAsyncStoryblok(route.path, {
+    version: "draft",
+    language: "en",
+    resolve_relations: ["popular-articles.articles"]
+  });
+} catch (error) {
+  console.log(error);
+}
+</script>
+
+<template>
+  <div>
+    {{ story }}
+  </div>
+</template>