Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling on useAsyncStoryblok #317

Closed
alvarosabu opened this issue Feb 28, 2023 · 6 comments · Fixed by #398
Closed

Better error handling on useAsyncStoryblok #317

alvarosabu opened this issue Feb 28, 2023 · 6 comments · Fixed by #398
Assignees
Labels
dx [Issue] Improvement or fix with impact on the developer experience. enhancement [Issue][PR] New feature

Comments

@alvarosabu
Copy link
Contributor

Improve the error handling on the composable useAsyncStoryblok to provide the user with more accurate information.


@alvarosabu alvarosabu added enhancement [Issue][PR] New feature dx [Issue] Improvement or fix with impact on the developer experience. labels Feb 28, 2023
@SebbeJohansson
Copy link
Contributor

SebbeJohansson commented Feb 28, 2023

Maybe it shouldn't use the internal nuxt3 one... maybe that was a mistake.

@Dawntraoz
Copy link
Contributor

This issue is already being discussed at #329

@Dawntraoz
Copy link
Contributor

We will pass the error to the call directly. #398

@SebbeJohansson
Copy link
Contributor

@Dawntraoz Interesting changes. Especially the change to useState as the suggested way to do SSR. Has this been tested for generating static pages during build/generate?

@Dawntraoz
Copy link
Contributor

Hi @SebbeJohansson, indeed, that was the first test actually. You can reproduce it by using the npm link if you want or running the playground as static in the branch used for the PR.

And the use of the useState without useAsyncData was the way the Nuxt team recommend us to do it in our last conversation, that's why.

@SebbeJohansson
Copy link
Contributor

@Dawntraoz amazing! Thanks for all the hard work 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx [Issue] Improvement or fix with impact on the developer experience. enhancement [Issue][PR] New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants