Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor the async composable to use native fetch and useState only #398

Merged
merged 15 commits into from
Jul 25, 2023

Conversation

Dawntraoz
Copy link
Contributor

@Dawntraoz Dawntraoz commented May 3, 2023

Refactor the useAsyncStoryblok composable to use useState and be able to handle errors on the page level.

@Dawntraoz Dawntraoz self-assigned this May 3, 2023
@Dawntraoz Dawntraoz added improvement [Issue][PR] Refactor or code improvement bugfix [PR] Fixes a bug labels May 3, 2023
@Dawntraoz
Copy link
Contributor Author

@alvarosabu @alexjoverm I need your help to review why when we generate the static version, the error page is not shown, but it works fine locally :S I've already tried so many things but no luck, I guess I need some fresh eyes on it <3

@alvarosabu
Copy link
Contributor

need your help to review why when we generate the static version, the error page is not shown, but it works fine locally :S I've already tried so many things but no luck, I guess I need some fresh eyes on it <3

I think the error page is a feature only for SSR and SPA, since it's not a route (is on the root directory, not in the pages directory) the command npm run generate will not prerender it.

For static I guess you would need to add an error page on pages and just deal with the error handling manually

README.md Show resolved Hide resolved
@Dawntraoz Dawntraoz linked an issue Jul 17, 2023 that may be closed by this pull request
1 task
@annejan89
Copy link

bump, without this PR Nuxt3 with Storyblok is useless

@Dawntraoz Dawntraoz merged commit 00cea7f into main Jul 25, 2023
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Dawntraoz Dawntraoz deleted the fix/refactor-useAsyncStoryblok branch October 17, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix [PR] Fixes a bug improvement [Issue][PR] Refactor or code improvement released
Projects
None yet
4 participants