Support for the new Figma share URL #240
Merged
+23
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocka
commented
May 17, 2024
packages/storybook-addon-designs/src/manager/components/Figma.tsx
Outdated
Show resolved
Hide resolved
|
I gave this a test on my end, and it did the trick! Nice one @pocka Looks like it's just the regex failing on Codacy. I don't see any harm any updating to align with Codacy's requirements, even if Figma docs have a slightly different regex pattern? Otherwise, is there a way to disable the static code analysis warning on that line, with Codacy? |
ghengeveld
approved these changes
May 29, 2024
ghengeveld
reviewed
May 29, 2024
packages/storybook-addon-designs/src/manager/components/Figma.tsx
Outdated
Show resolved
Hide resolved
|
any updates when this should be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #239
Figma changed URL structure for the share URL from
"/file/..."to"/<anything>/...". This patch updates the URL checking regexp according to their updated embed document.📦 Published PR as canary version:
8.0.3--canary.240.540483c.0✨ Test out this PR locally via: