Merge pull request #141 from storybookjs/yann/allow-storybook-test

use-storybook-expect: allow @storybook/test imports
storybookjs · Sep 20, 2023 · f1ffa5e · f1ffa5e
2 parents 611b70e + 5447e45
commit f1ffa5e
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/rules/use-storybook-expect.ts b/lib/rules/use-storybook-expect.ts
@@ -45,8 +45,11 @@ export = createStorybookRule<TDefaultOptions, string>({
     //----------------------------------------------------------------------
 
     const isExpectFromStorybookImported = (node: TSESTree.ImportDeclaration) => {
+      const { value: packageName } = node.source
+      const usesExpectFromStorybook =
+        packageName === '@storybook/jest' || packageName === '@storybook/test'
       return (
-        node.source.value === '@storybook/jest' &&
+        usesExpectFromStorybook &&
         node.specifiers.find((spec) => isImportSpecifier(spec) && spec.imported.name === 'expect')
       )
     }

diff --git a/tests/lib/rules/use-storybook-expect.test.ts b/tests/lib/rules/use-storybook-expect.test.ts
@@ -29,6 +29,23 @@ ruleTester.run('use-storybook-expect', rule, {
     dedent`
       import { expect } from '@storybook/jest';
 
+      export const Basic = {
+        ...Default,
+        play: async (context) => {
+          expect(123).toEqual(123);
+        },
+      };
+    `,
+    dedent`
+      import { expect } from '@storybook/test';
+
+      Default.play = () => {
+        expect(123).toEqual(123);
+      }
+    `,
+    dedent`
+      import { expect } from '@storybook/test';
+
       export const Basic = {
         ...Default,
         play: async (context) => {