Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Make the test-runner tests fail on console.error #23783

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 10, 2023

What I did

Recently we discovered a bug in #23782 and it could have been avoided if the test-runner failed on console.error messages, so this PR adds that functionality to the test-runner runs in CI (and local).

How to test

  1. Run a test-runner task for a template, e.g. yarn task --task test-runner --start-from auto --template react-vite/default-ts

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added build Internal-facing build tooling & test updates ci:normal labels Aug 10, 2023
@kylegach kylegach merged commit 28b5077 into next Aug 14, 2023
15 checks passed
@kylegach kylegach deleted the build/fail-on-console-error-test-runner branch August 14, 2023 14:48
@github-actions github-actions bot mentioned this pull request Aug 15, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants