Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Upgrade Addon Design #23806

Merged
merged 1 commit into from
Aug 11, 2023
Merged

UI: Upgrade Addon Design #23806

merged 1 commit into from
Aug 11, 2023

Conversation

cdedreuille
Copy link
Contributor

@cdedreuille cdedreuille commented Aug 11, 2023

What I did

Related to this bug, this PR updates the design addon package in the manager

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@cdedreuille cdedreuille added maintenance User-facing maintenance tasks ci:normal labels Aug 11, 2023
@cdedreuille cdedreuille self-assigned this Aug 11, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yannbf yannbf added build Internal-facing build tooling & test updates and removed maintenance User-facing maintenance tasks labels Aug 11, 2023
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it!!!

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @storybook/[email protected]

@cdedreuille cdedreuille merged commit 8e6cfb4 into next Aug 11, 2023
20 of 22 checks passed
@cdedreuille cdedreuille deleted the charles-upgrade-addon-design branch August 11, 2023 13:43
@vanessayuenn vanessayuenn added dependencies and removed build Internal-facing build tooling & test updates labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants