Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix actions addon "cannot read count" error #23910

Closed
wants to merge 1 commit into from
Closed

fix actions addon "cannot read count" error #23910

wants to merge 1 commit into from

Conversation

garrett-hopper
Copy link

I ran into this error when using the actions plugin on version 7.3.2

Specifically coming from addons/actions/src/manager.tsx#L13, where c would initially be undefined.

manager-bundle.js:150 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'count')
    at manager-bundle.js:150:13268
    at Object.setAddonState (chunk-UBXIQABM.js:39:13762)
    at setState (chunk-UBXIQABM.js:53:35093)
    at chunk-UBXIQABM.js:53:36196
    at storybook/actions/action-event (manager-bundle.js:150:13248)
    at chunk-UBXIQABM.js:39:3795
    at Array.forEach (<anonymous>)
    at Channel.handleEvent (chunk-UBXIQABM.js:39:3779)
    at PostMessageTransport.<anonymous> (chunk-UBXIQABM.js:39:2430)
    at PostMessageTransport.handler (chunk-UBXIQABM.js:39:5469)

What I did

Added a optional chain and nullish coalesce to default count to 0

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

No manual testing necessary

Documentation

N/A

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf
Copy link
Member

yannbf commented Aug 22, 2023

@kasperpeulen can you take a look? Seems like you worked on this as well

@kasperpeulen
Copy link
Contributor

Might be solved with this PR:
#23804

@garrett-hopper
Copy link
Author

Might be solved with this PR: #23804

Looks like it; closing

@garrett-hopper garrett-hopper deleted the count-error branch August 23, 2023 01:11
@ndelangen
Copy link
Member

Thank you for contributing @garrett-hopper !
Sorry your PR wasn't able to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants