Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove key from addon render docs #25530

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

reyronald
Copy link
Contributor

@reyronald reyronald commented Jan 9, 2024

@reyronald reyronald marked this pull request as ready for review January 9, 2024 22:30
@reyronald reyronald changed the title Remoe key from addon render docs docs: Remoe key from addon render docs Jan 9, 2024
@reyronald reyronald changed the title docs: Remoe key from addon render docs docs: Remove key from addon render docs Jan 10, 2024
@jonniebigodes jonniebigodes self-assigned this Jan 13, 2024
@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Jan 13, 2024
@jonniebigodes jonniebigodes changed the title docs: Remove key from addon render docs Docs: Remove key from addon render docs Jan 16, 2024
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reyronald, thanks for putting together this pull request and helping us improve the documentation by addressing this removal from our addon ecosystem. We appreciate it 🙏 ! I've checked, and all is good on my end. I'm going to merge it once the checklist clears.

Hope you have a fantastic day.

Stay safe

@jonniebigodes jonniebigodes merged commit 1915bbc into storybookjs:next Jan 16, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Jan 17, 2024
21 tasks
@reyronald
Copy link
Contributor Author

No problem! Thank you for such a wonderful tool. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants