Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addon install command #225

Merged
merged 3 commits into from
Jan 26, 2025
Merged

Fix addon install command #225

merged 3 commits into from
Jan 26, 2025

Conversation

kkuegler
Copy link
Contributor

@kkuegler kkuegler commented Sep 1, 2024

The command copied to the clipboard was different from the one displayed. It erroneously used 'npx' instead of 'npm'. Now we use 'npm' consistently.

In addition, we add the '-D' flag to add the addon to dev dependencies, which is what people usually want to do.

The command copied to the clipboard was different from the one
displayed. It erroneously used 'npx' instead of 'npm'. Now we use
'npm' consistently.

In addition, we add the '-D' flag to add the addon to dev dependencies,
which is what people usually want to do.
Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for storybook-addon-catalog ready!

Name Link
🔨 Latest commit c40240b
🔍 Latest deploy log https://app.netlify.com/sites/storybook-addon-catalog/deploys/6795b48fd84a9c000808c13c
😎 Deploy Preview https://deploy-preview-225--storybook-addon-catalog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for storybook-frontpage ready!

Name Link
🔨 Latest commit c40240b
🔍 Latest deploy log https://app.netlify.com/sites/storybook-frontpage/deploys/6795b48f4e215d0008b1c8b7
😎 Deploy Preview https://deploy-preview-225--storybook-frontpage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Sep 1, 2024

@kkuegler is attempting to deploy a commit to the Storybook Team on Vercel.

A member of the Team first needs to authorize it.

@cdedreuille cdedreuille self-requested a review September 1, 2024 22:37
Copy link
Collaborator

@cdedreuille cdedreuille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for spotting that bug @kkuegler

Copy link

vercel bot commented Sep 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 8:43am
web-addon-catalog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 8:43am

@kkuegler
Copy link
Contributor Author

kkuegler commented Oct 3, 2024

Hi @cdedreuille, thanks for accepting the PR!

I just wanted to check in because you merged storybookjs:main into my repo, but not (yet) the other way around. Maybe that was an oversight.

@kkuegler
Copy link
Contributor Author

kkuegler commented Dec 4, 2024

It seems Carles no longer works for Chromatic/on Storybook.

@kylegach Could you potentially take over this PR?

@AndreyYolkin
Copy link

Oh, I forgot to check PRs first and opened related issue #258

@kkuegler
Copy link
Contributor Author

Hehe, maybe the issue actually helps with someone noticing and merging this PR. <3

@shilman
Copy link
Member

shilman commented Jan 26, 2025

Thanks for the contribution and your patience!

@shilman shilman merged commit d757190 into storybookjs:main Jan 26, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants