Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add docs page tabs #259

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Re-add docs page tabs #259

merged 2 commits into from
Jan 29, 2025

Conversation

kylegach
Copy link
Collaborator

@kylegach kylegach commented Jan 28, 2025

The Component Story Format (CSF) page showing two page-level tabs, CSF 3 and CSF Factories (Experimental). The second tab is active.

How to test

To see the docs page tabs, the content had to be updated. Therefore, a demo PR was created for testing.

You will not be able to test in this PR's deploy preview.

  1. You should see functional page-level tabs on this page (which is built from these content changes):

    https://deploy-preview-260--storybook-frontpage.netlify.app/docs/8.6/api/csf

    Confirm that the other tab's URL is /docs/8.6/api/csf/csf-factories. The actual content there is WIP and not relevant to this PR.

  2. And you should not see them on this page:

    https://deploy-preview-260--storybook-frontpage.netlify.app/docs/api/csf

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for storybook-frontpage ready!

Name Link
🔨 Latest commit 401e347
🔍 Latest deploy log https://app.netlify.com/sites/storybook-frontpage/deploys/679a3eadfde6500008bc414b
😎 Deploy Preview https://deploy-preview-259--storybook-frontpage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for storybook-addon-catalog ready!

Name Link
🔨 Latest commit 401e347
🔍 Latest deploy log https://app.netlify.com/sites/storybook-addon-catalog/deploys/679a3ead58c93b0008b4aa2c
😎 Deploy Preview https://deploy-preview-259--storybook-addon-catalog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kylegach kylegach self-assigned this Jan 28, 2025
@winkerVSbecks
Copy link
Contributor

Copy link
Contributor

@winkerVSbecks winkerVSbecks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is causing the deploy to error out but otherwise good to merge

@kylegach
Copy link
Collaborator Author

deploy-preview-260--storybook-frontpage.netlify.app/docs/api/csf seems to error out

Strange. It works in a local build and in the redeploy I just did, so I'm going to consider that a fluke.

Thanks for the review!

@kylegach kylegach merged commit 7542651 into main Jan 29, 2025
12 checks passed
@kylegach kylegach deleted the docs-page-tabs branch January 29, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants