Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

age: Add scrypt::Recipient::set_work_factor for overriding default #520

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

str4d
Copy link
Owner

@str4d str4d commented Aug 28, 2024

This can only be configured by using scrypt::Recipient directly in a library context. The helper method Encryptor::with_user_passphrase does not expose this, and rage continues to use the default.

Closes #383.

@str4d str4d added this to the rage 0.11.0 milestone Aug 28, 2024
str4d added 2 commits August 28, 2024 05:16
This can only be configured by using `scrypt::Recipient` directly in a
library context. The helper method `Encryptor::with_user_passphrase`
does not expose this, and `rage` continues to use the default.

Closes #383.
They are now consistent with `scrypt::Recipient::set_work_factor`.
@str4d str4d force-pushed the 383-scrypt-enc-work-factor branch from 7e67717 to 67a5397 Compare August 28, 2024 05:16
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.87%. Comparing base (84eacb7) to head (67a5397).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
+ Coverage   50.71%   50.87%   +0.15%     
==========================================
  Files          42       42              
  Lines        4121     4124       +3     
==========================================
+ Hits         2090     2098       +8     
+ Misses       2031     2026       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@str4d str4d merged commit b179b7c into main Aug 28, 2024
37 checks passed
@str4d str4d deleted the 383-scrypt-enc-work-factor branch August 28, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PBE default work factor can cause OOM issues on memory-constrained environments
1 participant