fix(models/gemini): handle non-JSON error messages from Gemini API #1062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid a raw JSONDecodeError when the Gemini API returns an empty or non-JSON error message (for example on an invalid API key).This PR:
Catches json.JSONDecodeError when parsing error.message, logs a warning with context (error_message=<...> | Gemini API returned non-JSON error), and re-raises the original genai.errors.ClientError with the JSON error as the explicit cause.
Adds a unit test (test_stream_handles_non_json_error) to verify a non-JSON error is logged and the original ClientError is propagated
Related Issues
#1024
Documentation PR
N/AType of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.