feat: Add sentry svc creation logic to connect with horcrux-proxy automatically #428
+51
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If set sentry mode, private validator will be horcrux what is connected through horcrux-proxy. In horcrux-proxy, it has automatic discover service logic but cosmos-operator doesn't have automatic service creation logic. through this improvement, horcrux, horcrux-proxy, and cosmos fullnode will be connected automatically.
|
this feature is wanted. |
|
This is a great feature! We will want test cases before we can merge, but we will start testing this out in the next week or so. |
Based on suggestion Co-authored-by: Leo Pang <[email protected]>
Based on suggestion Co-authored-by: Leo Pang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If set sentry mode, private validator will be horcrux what is connected through horcrux-proxy.
In horcrux-proxy, it has automatic discover service logic but cosmos-operator doesn't have automatic service creation logic.
through this improvement, horcrux, horcrux-proxy, and cosmos fullnode will be connected automatically.