Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use agoric's synchetic chain image #211

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

toliaqat
Copy link

@toliaqat toliaqat commented Jan 20, 2024

This PR utilizes the Agoric chain's mainnet synthetic chain Docker image from the Agoric-3-proposals repo, rather than replicating the Agoric chain build process. This image includes all the upgrade proposals made to the agoric mainnet.

Testing was conducted using the following commands.

./heighliner build -c agoric -g main
docker run -it --rm --entrypoint sh agoric:main

Copy link

@ivanlei ivanlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been able to use this successfully but needed to hand edit the agoric docker image to build from

FROM ghcr.io/strangelove-ventures/infra-toolkit:v0.1.0 AS infra-toolkit
RUN addgroup --gid 1025 -S heighliner && adduser --uid 1025 -S heighliner -G heighliner

FROM ghcr.io/agoric/agoric-3-proposals:main
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toliaqat - could this be turned into an ARG AGORIC_BASE_IMAGE such that someone could run something akin to:

heighliner build -c agoric -g main --build-env 'AGORIC_BASE_IMAGE="ghcr.io/agoric/agoric-3-proposals:myprivatetag"

@agouin
Copy link
Member

agouin commented Mar 4, 2024

Thanks for the PR @toliaqat ! We already have the imported dockerfile for this purpose however, which enables building on top of existing docker repository images. We actually built with that initially for agoric before we switched to build agoric from source. I think it would be better to switch agoric back to the imported dockerfile and extend the imported dockerfile if necessary than bring in an agoric specific dockerfile.

You can see in this PR #130 that we switched from the imported dockerfile to the build from source approach. We like to build from source wherever possible with heighliner, but importing from an existing registry is an approach we can consider also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants