-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: use authority admin, remove params #184
Conversation
A single You can even set the This is what we do on Manifest. |
I'll go the 2nd approach way with just using the standard authority as the admin. The complexity to support an array is far too much and not worth it relative to just using groups or DAOs. Also, we could just entirely delete params to remove the graceful exit logic. hmm Then will move optional POA admin override into the POA module itself for testing vs being done app side. nicer UX |
Sim failures due to hardcoded authority account now (instead of from params) |
ref: liftedinit/manifest-ledger#21
The way the SDK handles authorities is so difficult to have many admins and is going to be very confusing for people.
Maybe we only let 1 entity be the admin (set blank keeper up to load params, setup everything else, then finish keeper setup). This way every authority can be the p.Admin param from the POAKeeper
Idea 2