Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: use authority admin, remove params #184

Merged
merged 21 commits into from
Aug 5, 2024

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented May 25, 2024

ref: liftedinit/manifest-ledger#21

The way the SDK handles authorities is so difficult to have many admins and is going to be very confusing for people.

Maybe we only let 1 entity be the admin (set blank keeper up to load params, setup everything else, then finish keeper setup). This way every authority can be the p.Admin param from the POAKeeper

Idea 2

  • Just remove / ignore admins in the params store, weod not need
  • Only use authority for any logic. IsAdmin is just the k.authority
  • Fix e2e
  • Fix simulator

@Reecepbcups Reecepbcups changed the title fix!: the master admin is not the admin of itself fix!: master admin is not the admin of itself May 25, 2024
@fmorency
Copy link
Contributor

fmorency commented Jun 5, 2024

A single x/group account covers the multiple administrators use case.

You can even set the x/group policy to be the sole admin of the group, i.e., the group is the admin of itself.

This is what we do on Manifest.

@Reecepbcups
Copy link
Member Author

Reecepbcups commented Jul 16, 2024

I'll go the 2nd approach way with just using the standard authority as the admin. The complexity to support an array is far too much and not worth it relative to just using groups or DAOs.

Also, we could just entirely delete params to remove the graceful exit logic. hmm

Then will move optional POA admin override into the POA module itself for testing vs being done app side. nicer UX

@Reecepbcups Reecepbcups changed the title fix!: master admin is not the admin of itself fix!: use authority admin, remove params Jul 17, 2024
@Reecepbcups
Copy link
Member Author

Reecepbcups commented Jul 23, 2024

Sim failures due to hardcoded authority account now (instead of from params)

keeper/keeper.go Show resolved Hide resolved
errors.go Outdated Show resolved Hide resolved
@Reecepbcups Reecepbcups marked this pull request as ready for review August 5, 2024 14:58
@Reecepbcups Reecepbcups merged commit d321226 into main Aug 5, 2024
13 checks passed
@Reecepbcups Reecepbcups deleted the reece/add-authority-to-keeper-admin branch August 5, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants