Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: pem.extensions.isCA -> pem.isCA, remove 'new' before 'Buffer.from' #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

magom001
Copy link

pem.extensions if an array and does not have isCA property. Statement always returns true.
Buffer.from is a factory method.

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   12.66%   12.66%           
=======================================
  Files           5        5           
  Lines         387      387           
=======================================
  Hits           49       49           
  Misses        338      338           
Impacted Files Coverage Δ
src/Webauthn.js 13.22% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d63d2...ab31035. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant