Fix S key in Ask AI modal triggering the MeiliSearch modal #2786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
pr: updated content
pwizla
added
pr: chore
and removed
pr: updated content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a hacky fix to an unintended consequence of the new MeiliSearch modal introduction. It seems like pressing the S key triggers the opening of the MeiliSearch modal 😅
We're stopping immediate propagation once the Kapa modal is open to avoid this weird behavior, and allow some keyboard keys (arrows, Enter, Tab) to pass.
This is intended to be a temporary fix while we report the bug to Kapa and MeiliSearch teams and found another solution (like disabling the S shortcut at the config. level)