Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lsblk to "stratis pool report" #1044

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add lsblk to "stratis pool report" #1044

wants to merge 12 commits into from

Commits on Dec 4, 2023

  1. Add stub function to stratis for pool report subcommand 

    Signed-off-by: mulhern <[email protected]>
    @mulkieran
    mulkieran committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    7f5f8a6 View commit details
    Browse the repository at this point in the history

  2. Use new classes to manage some shared abstractions 

    There are some new classes introduced to handle unpacking the
StoppedPools property and also to select a pool by UUID or name. Use
them in the report functionality.

Signed-off-by: mulhern <[email protected]>
    @mulkieran
    mulkieran committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    1181978 View commit details
    Browse the repository at this point in the history

  3. Add lsblk command 

    Signed-off-by: Bryan Gurney <[email protected]>
    @bgurney-rh @mulkieran
    bgurney-rh authored and mulkieran committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    37330ba View commit details
    Browse the repository at this point in the history

  4. Now need to get the devnode explicitly 

    Signed-off-by: mulhern <[email protected]>
    @mulkieran
    mulkieran committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    f834f73 View commit details
    Browse the repository at this point in the history

  5. Call lsblk from absolute path

    @bgurney-rh @mulkieran
    bgurney-rh authored and mulkieran committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    fe946da View commit details
    Browse the repository at this point in the history

  6. Ignore bandit B603 errors for processed input

    @bgurney-rh @mulkieran
    bgurney-rh authored and mulkieran committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    21e15a6 View commit details
    Browse the repository at this point in the history

  7. Fix stopped pool report command

    @bgurney-rh @mulkieran
    bgurney-rh authored and mulkieran committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    8b8f080 View commit details
    Browse the repository at this point in the history

  8. Use list comprehension for stopped pool lsblk

    @bgurney-rh @mulkieran
    bgurney-rh authored and mulkieran committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    30e9bea View commit details
    Browse the repository at this point in the history

  9. Remove for loop from stopped pool lsblk

    @bgurney-rh @mulkieran
    bgurney-rh authored and mulkieran committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    a3092a5 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Add some simple tests for coverage 

    Signed-off-by: mulhern <[email protected]>
    @mulkieran
    mulkieran committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    1ac5d94 View commit details
    Browse the repository at this point in the history

  2. Add test for reporting on stopped pools 

    Signed-off-by: mulhern <[email protected]>
    @mulkieran
    mulkieran committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b2bf57f View commit details
    Browse the repository at this point in the history

  3. Add no cover pragmas where appropriate 

    Signed-off-by: mulhern <[email protected]>
    @mulkieran
    mulkieran committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    848b1de View commit details
    Browse the repository at this point in the history