last changes

stratum-mining · Jan 26, 2024 · 22f43fe · 22f43fe
1 parent b1f815b
commit 22f43fe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/protocols/v2/roles-logic-sv2/src/channel_logic/channel_factory.rs b/protocols/v2/roles-logic-sv2/src/channel_logic/channel_factory.rs
@@ -1499,6 +1499,8 @@ impl ProxyExtendedChannelFactory {
             let error = SubmitSharesError {
                 channel_id: m.channel_id,
                 sequence_number: m.sequence_number,
+                // Infallible unwrap we already know the len of the error code (is a
+                // static string)
                 error_code: SubmitSharesError::invalid_job_id_error_code()
                     .to_string()
                     .try_into()

diff --git a/roles/translator/src/lib/downstream_sv1/diff_management.rs b/roles/translator/src/lib/downstream_sv1/diff_management.rs
@@ -243,6 +243,8 @@ impl Downstream {
                     || (hashrate_delta_percentage >= 30.0) && (delta_time >= 240)
                     || (hashrate_delta_percentage >= 15.0) && (delta_time >= 300)
                 {
+                // realized_share_per_min is 0.0 when d.difficulty_mgmt.submits_since_last_update is 0
+                // so it's safe to compare realized_share_per_min with == 0.0
                 if realized_share_per_min == 0.0 {
                     new_miner_hashrate = match delta_time {
                         dt if dt <= 30 => d.difficulty_mgmt.min_individual_miner_hashrate / 1.5,