Skip to content

Commit

Permalink
fix GetSize for SubmitSolutionJd
Browse files Browse the repository at this point in the history
the GetSize implementation is not accounting for self.version.get_size()!

that is causing NoiseEncoder to allocate a buffer that's smaller than what is actually needed, which eventually triggers FramingSv2Error(BinarySv2Error(WriteError)) during encoding
  • Loading branch information
plebhash authored and GitGab19 committed Jun 28, 2024
1 parent cfcb972 commit 29c9acc
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,6 @@ impl<'d> GetSize for SubmitSolutionJd<'d> {
+ self.ntime.get_size()
+ self.nonce.get_size()
+ self.nbits.get_size()
+ self.version.get_size()
}
}

0 comments on commit 29c9acc

Please sign in to comment.